feat: Implement an Unknown variant in the artifact locations #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sfauvel
force-pushed
the
sfa/2293/support_evolving_cloud_artifact_locations_type
branch
2 times, most recently
from
4fed3dd to
21f5408
Compare
sfauvel
force-pushed
the
sfa/2293/support_evolving_cloud_artifact_locations_type
branch
from
21f5408 to
fb0d566
Compare
sfauvel
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
sfauvel
force-pushed
the
sfa/2293/support_evolving_cloud_artifact_locations_type
branch
from
4bdacfb to
320e040
Compare
sfauvel
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
approved these changes
Feb 19, 2025
dlachaume
approved these changes
Feb 19, 2025
sfauvel
force-pushed
the
sfa/2293/support_evolving_cloud_artifact_locations_type
branch
from
320e040 to
a6a70c7
Compare
sfauvel
force-pushed
the
sfa/2293/support_evolving_cloud_artifact_locations_type
branch
2 times, most recently
from
08ec2d4 to
12fbdcd
Compare
sfauvel
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
sfauvel
force-pushed
the
sfa/2293/support_evolving_cloud_artifact_locations_type
branch
2 times, most recently
from
8057f74 to
c71501f
Compare
sfauvel
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
sfauvel
force-pushed
the
sfa/2293/support_evolving_cloud_artifact_locations_type
branch
from
c71501f to
569ef01
Compare
sfauvel
force-pushed
the
sfa/2293/support_evolving_cloud_artifact_locations_type
branch
2 times, most recently
from
4e1913d to
ea3cf6c
Compare
sfauvel
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
sfauvel
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
* mithril-client-cli from `0.11.1` to `0.11.2` * mithril-client from `0.11.3` to `0.11.4` * mithril-common from `0.5.5` to `0.5.6`
sfauvel
force-pushed
the
sfa/2293/support_evolving_cloud_artifact_locations_type
branch
from
c94651e to
8969387
Compare
sfauvel
had a problem deploying
to
testing-preview
GitHub Actions
Failure
sfauvel
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
sfauvel
deleted the
sfa/2293/support_evolving_cloud_artifact_locations_type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
To avoid creating a breaking change in the client whenever a new location is introduced (e.g. decentralized storage).
we add a fallback variant in the artifact location types for the Incremental Cardano DB.
This PR implements an Unknown variant with the #[serde(other)] macro (as explained here) in the artifact locations messages:
The `mithril-client-cli is adapted to not show unknown location.
Pre-submit checklist
Comments
Issue(s)
Relates to #2293